opentelemetry-collector icon indicating copy to clipboard operation
opentelemetry-collector copied to clipboard

Remove expandconverter

Open bogdandrutu opened this issue 2 years ago • 4 comments

Need to investigate if the current expand providers logic in the confmap.Resolver has all the equivalent functionality. Then we also need to propose some kind of deprecation process: e.g. disable by default via a featuregate; or other alternatives.

One caveat that I know and need to document is that because of this we have a workaround in prometheus receiver see the note here. Once this is disable that is no longer necessary which is a good thing, but may break some users so we need to find a way to handle/communicate that.

bogdandrutu avatar Feb 03 '23 17:02 bogdandrutu

but may break some users so we need to find a way to handle/communicate that.

We may want to have some sort of subcommand/flag/separate tool to migrate a config from the old syntax to the new one. This could be useful for other future changes in the configuration (whether breaking or just recommendations). If that sounds like a good idea, should we create a separate issue to discuss how to go about it?

mx-psi avatar Feb 08 '23 12:02 mx-psi

Let's start that issue. We definitely need it. I think the best we can do is to have it as a subcommand but this is just me prematurely commenting 👯

bogdandrutu avatar May 03 '23 05:05 bogdandrutu

See #7631 :)

mx-psi avatar May 04 '23 12:05 mx-psi

Per https://github.com/open-telemetry/opentelemetry-collector/issues/8215#issuecomment-1865028717 before doing this we need to add support for ${...} to the general expansion before removing this converter, to align with https://github.com/open-telemetry/opentelemetry-specification/pull/3744

mx-psi avatar Jan 04 '24 16:01 mx-psi