Bogdan Drutu

Results 550 comments of Bogdan Drutu

100% we should enforce latest (hopefully no CVEs) version when we build the final binary that we release as a binary, but for libraries like artifacts we cannot enforce this.

>Sure. Should I put it into experimental/pdata/pprofile (in which case pdatagen can't be used, has to be refactored or something else, as it only handles putting generated code into the...

> A FatalError can be used to fail fast during startup when detecting an unrecoverable error condition. An example would be a receiver that is unable to bind to its...

1. I think the "client" name of the package is too generic and confusing; 2. Some (if not all) of this can be part of the consumer package since it...

Please consider a big refactor (including renaming probably) for this package before marking stable.

> I expected TelemetrySettings to eventually include a LoggerProvider once the logging bridge API is implemented in otel-go. This makes me wonder if TelemetrySettings should be moved out of component...

> We should decide what to do with it (stabilize it, remove it, change it in some way) I want to remove it, since it was used to configure "high...

Also we duplicate the "net" prefix in `config[net].[Net]Addr` for example

Also, as a general rule all these "ToFoo" should have options in the signature for future proof and very important `Context` as first argument.