Brandon Bocklund

Results 150 comments of Brandon Bocklund

> I'm a big fan of this PR. I have noticed there are occasionally regions where the tielines don't seem to be rendered correctly. An example from AL-C is shown...

Closing in favor of #543

`wks.conditions` needs a `__str__` and/or `__repr__`

I'm just starting to use this a bit, I'm wondering if I missed if there's a hook to give units for `ModelComputedProperty` that are not derived from the energy. Specifically,...

I came across a bug for ternaries when using the cpf for mole fractions specified to be greater than one. Here's some code to reproduce: ```python @select_database("alnipt.tdb") def test_jansson_derivative_with_invalid_mass_conditions(load_database): """...

The test assumes that the value of `"GM"` should also be NaN for the invalid conditions, while it's currently zero. NaN is more consistent with the existing pre-workspace behavior, but...

Discussed a little out-of-band, we might make the Pint-based units support a little less intrusive initially. Maybe by being opt-in or somehow separating the units from returned quantities so there's...

It seems to me like this also - Closes https://github.com/pycalphad/pycalphad/issues/133 through the multi-valued output from `Workspace.get` - Closes https://github.com/pycalphad/pycalphad/issues/163 because site fraction conditions can be given now

Capturing some in-person discussion: We're going to factor the `pycalphad.plot.renderers.Renderer` class out into a separate branch. We want to integrate mapping into `Workspace` so that there is something like `Workspace.map()`...

From #476, the database now reads without errors. With new mapping merged in #543, I think the step diagrams should be improved. Do you have the compositions @AshoreMrFish for us...