Brandon Bocklund
Brandon Bocklund
Small fix for a unary 2D mapping. Can probably pick any unary system with T/P mapping for a test. ```patch diff --git a/pycalphad/mapping/zpf_equilibrium.py b/pycalphad/mapping/zpf_equilibrium.py index 4a4a52d3..344cecef 100644 --- a/pycalphad/mapping/zpf_equilibrium.py +++...
Trying to get to a more formal review soon, but a few mapping feature requests: 1. Automatic axis labels should have units where applicable (e.g. `"Temperature"` should be `"Temperature (K)"`)...
@nury12n sorry I've gotten away from this. Assuming we get #622 and #627 in so tests are passing again, is there anything you're still working on or is this ready...
Yes, I think we should use the shorthand notation for all units in plots by default and if we can also _not_ have "(fraction)" printed as a unit where it...
should be good to merge develop in now
> Apart from having to think more about the `StrategyData` renaming, I would argue to have #605 merged before this branch, so we can check if any of the changes...
Also, does this branch address https://github.com/pycalphad/pycalphad/issues/624? It's okay if it's out of scope, but would be nice to close, if possible
Merged develop
This can close #600 for me for now ``` ================================================================================================================== slowest 20 durations =================================================================================================================== 8.03s call pycalphad/tests/test_workspace.py::test_tzero_property[alzn_mey.tdb] 4.52s call pycalphad/tests/test_plot.py::test_binplot[Al-Mg_Zhong.tdb] 4.18s call pycalphad/tests/test_equilibrium.py::test_eq_needs_metastable_starting[mc_fecocrnbti.tdb] 3.95s call pycalphad/tests/test_property_framework.py::test_cpf_tzero[alzn_mey.tdb] 2.89s call pycalphad/tests/test_database.py::test_long_constituent_line_writes_correctly 2.69s...
@nury12n can you look into coverage? Seems like maybe we could do with tests on new `__str__` and `__repr__` functions. Those seemed like easy wins worth testing.