Brandon Bocklund
Brandon Bocklund
Thank you, I think this is working for my immediate need
@nury12n one of the mapping tests (`test_check_global_min`) fails with the exception ``` # check_change_in_phases for same phase becoming unstable and new node could not be found -> zpf line failed...
> The issue was that the third part was written incorrectly. When mapping (and in this unit test), we step the conditions by update_equilibrium_with_new_conditions to get a step_result, which contains...
As far as tweaking hyperparamters, I made the following superficial change to allow running the tests without recompiling: ```python diff --git a/pycalphad/core/minimizer.pxd b/pycalphad/core/minimizer.pxd index 466fffca..925b8246 100644 --- a/pycalphad/core/minimizer.pxd +++ b/pycalphad/core/minimizer.pxd...
Thanks for the review :) > Is this part of the pull request? The current state of the `ENH-convergence-improvements` branch doesn't show these changes, but I kind of like the...
Does #432 close this issue? Workspace would implement this as loopy code. I think it's fair to say that we don't plan to implement an API to disable broadcasting by...
The ordering model is really subtle, and I think we should try to emulate how Thermo-Calc handles it as much as possible. The detailed requirements list is enumerated here: https://github.com/pycalphad/pycalphad/issues/345#issuecomment-938201106...
@kolotinsky1998 thanks for the detailed issue. Indeed the `ternplot` puts things on triangular axes which doesn't interact well with matplotlib resizing. If you're going to zoom in at all, I...
I've been trying some today, but haven't been able to create a pure SymEngine reproducer. Between 0.13 and 0.14, commit `50310f008` in the C++ library changed `symengine/serialize-cereal.h` such that `RCPBasicAwareOutputArchive.save_rcp_basic`...
Not that I know of, but it's not impossible. We've been pinned in PyCalphad to SymEngine==0.13 and it's been totally stable and several different people and machines can reproduce (with...