Ben Barham comments

Results 117 comments of


                                            Ben Barham

Diagnostic formatter doesn't account for grapheme length in its column annotations

https://github.com/apple/swift-syntax/pull/1365

Diagnostic formatter doesn't account for grapheme length in its column annotations

Ah whoops, that's where Doug noticed the issue, not where it's fixed :)

swift-syntax compiles much more slowly with WMO enabled

rdar://103933042

[Serialization] Display contextual notes on deserialization errors and misconfigurations

``` :0: note: declarations in the underlying clang module 'A' may be hidden by clang project settings :0: note: the distributed module 'LibWithXRef' refers to the local module 'A'; this...

[Serialization] Display contextual notes on deserialization errors and misconfigurations

> I like keeping the current error first as it's the problem to fix, whereas note: could not deserialize type for 'foo()' is a side-effect but not the root cause....

[CMake] Prevent rebuilds of pure swift libraries and executables

@swift-ci please test

[5.9][Macros] Test case for opt-out from automatic attrs propagation

@swift-ci please test

[android][test] Fix new C++ interop test on Android armv7 and new IRGen test, and disable CxxToSwiftToCxx bridging test that now fails on Android

@swift-ci please test

build: fix accidental cmake expansions

> Ok, thanks, I appreciate your efforts anyway and good to have some idea of the root cause. The above is against -next so I will try a -main build...

build: fix accidental cmake expansions

@swift-ci please test