Ben Barham comments

Results 117 comments of


                                            Ben Barham

[6.1][bazel] Update for new libraries

Where is this needed @keith? Just on the release branch or in a 601.* tag?

Adopt `swift-toolchain-sqlite` to reduce system dependencies

Suppose this is a question for @jakepetroules - should swift-toolchain-sqlite use the system dependency for Apple platforms, or is it intentional that all platforms are just using the amalgamation?

Adopt `swift-toolchain-sqlite` to reduce system dependencies

> See llbuild for example of usage. I was more wondering whether we think `swift-toolchain-sqlite` should do this itself (ie. have an empty target that depends on the system sqlite...

MemberAttributeMacro do not visit members that are guarded with IfConfigDecl

We should be able to handle this now with `SwiftIfConfig` with eg. an extra `BuildConfiguration` to the assertion. Note that this behaves as you'd expect during actual compilation, just not...

Sometimes a diagnostic warning appears only in the `Issue Navigator`, not in the `Editor` itself.

Thank you for the super simple reproducer + clear comments @RoBo-Inc! The issue here is that your `.filter` and `as ...` is actually creating a new syntax tree, so the...

Build performance issue of swift-testing

Swift Testing is now in the toolchain in 6.0, so there won't be any swift-syntax/swift-testing building time contributing to the tests now. Happy to close out @Kyle-Ye or are you...

Build performance issue of swift-testing

Thanks, let me know!