Ben Barham
Ben Barham
Can we limit this to Windows only then? And possibly also rename `EditorMode` to... something 😅? `OpenAsVolatile`? Any files opened by the editor are already in-memory anyway, so it seems...
> Hmm, with mmap'ed data, it needs to remain mapped right? Or is the data processed and then the buffer dropped? I would naively expect the latter, but it's quite...
@swift-ci please test
@swift-ci please test
Unfortunately this is expected today :( See https://github.com/swiftlang/sourcekit-lsp/blob/main/CONTRIBUTING.md#windows
I'll leave open since ideally we *would* improve things here.
> It's not clear from SE-0474 whether yielding mutating borrow should be accepted, or only mutating yielding borrow. @DougGregor @rjmccall -- Any insights here? I haven't been following the proposal...
> What do you think @bnbarham? The main issue I see is with the setter + initializer, since a macro that's intending to copy a whole node could now remove...
> Macros build as executables, link the early swift syntax build In the toolchain build or standalone? If the former, how are they being picked up at runtime? IIRC we...
> For the toolchain distribution, we should be using the toolchain build of swift-syntax though to avoid bloat Sure, that should be the case here - we should be passing...