Ben Straub

Results 339 comments of Ben Straub

I don't think we should trust `pharmaversadam` as a source. The compares should be done on the templates available on CRAN versus what is in being done in a PR...

@bundfussr good points So is pharmaverseadam an exact replica of admiral templates? I thought there was some alterations being done for NEST that we haven't adapted in admiral templates?? @manciniedoardo

> > @bundfussr good points > > So is pharmaverseadam an exact replica of admiral templates? I thought there was some alterations being done for NEST that we haven't adapted...

> > > > @bundfussr good points > > > > So is pharmaverseadam an exact replica of admiral templates? I thought there was some alterations being done for NEST...

* if we incorporate into admiralci then extensions should get this update as well

Stay focused on admiral first and then we need to consider extension packages

> > > > > @bundfussr good points > > > > > So is pharmaverseadam an exact replica of admiral templates? I thought there was some alterations being done...

Looking nice @ProfessorP-beep! Can you just run styler on your code

> I'm still getting the error with pkgdown::build_site(), but everything else, including running the .Rmd checks out. It's running again right now after merging an update. I will see if...

I was able to build website - I will review PR. @manciniedoardo can you also help with review please.