Ben Straub comments

Results 339 comments of


                                            Ben Straub

General Issue: `CHG` and `PCHG` populated for Baseline and pre-baseline records in the templates

> Updated ADVS template to use restrict_derivation() with filter AVISITN > 0 for CHG and PCHG derivations, comments were also revised to mention post-baseline. Could you create a Pull Request...

Closes #2468 derive_vars_crit_flag: add 1.1.1 updates to cheatsheet

Waiting on RStudio to approve - could be a while!!

Documentation: `derive_vars_dt()`

Probably should improve that error message and not have `mutate()` in it! @pharmaverse/admiral I think we could apply a check on date_imputation for sure.

Documentation: `derive_vars_dt()`

@StefanThoma just checking in on the progress of this issue

General Issue: Verify template results

I would be hesitant to make these into unit tests as they are very big files to run. The current CI check for the templates is a separate workflow. I...

General Issue: Verify template results

What about how Edoardo approached that new check in the blog? He sources a file in the workflow - maybe something to consider? Then you could grab the file and...

General Issue: Verify template results

> > > The downside with a separate run is that you cannot run it locally, afaik. > > > > > > We could implement a function which runs...

General Issue: Verify template results

Thanks! I’ll start making a list of our datasets and potential keys

General Issue: Verify template results

No progress from my end, but eager to set this up as it causes a lot of consternation. Actually looking to do something similar in the Pliot R Submissions as...

General Issue: Verify template results

Converting this to a discussion and will link in the Roadmap