Closes #2415 replaced hard coding of expr(USUBJID, STUDYID) or expr(USUBJID) with …

[ProfessorP-beep]

…!!!get_admiral_option("subject_keys") to allow for flexibility in using the function. There is an error in the bds_exposure.Rmd markdown on line 361, chunk 22 that needs to be fixed.

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

• [x] Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
• [x] Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
• [x] Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
• [x] If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
• [x] Review the Cheat Sheet. Make any required updates to it by editing the file inst/cheatsheet/admiral_cheatsheet.pptx and re-upload a PDF version of it to the same folder.
• [x] Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family.
• [x] Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
• [x] Address any updates needed for vignettes and/or templates
• [x] Update NEWS.md under the header # admiral (development version) if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers). A Developer Notes section is available in NEWS.md for tracking developer-facing issues.
• [x] Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
• [x] Address or fix all lintr warnings and errors - lintr::lint_package()
• [x] Run R CMD check locally and address all errors and warnings - devtools::check()
• [x] Link the issue in the Development Section on the right hand side.
• [x] Address all merge conflicts and resolve appropriately
• [x] Pat yourself on the back for a job well done! Much love to your accomplishment!

[github-actions[bot]]

Package	Line Rate	Health
admiral	96%	✔
Summary	96% (4883 / 5082)	✔

[bms63]

Looking nice @ProfessorP-beep! Can you just run styler on your code

[ProfessorP-beep]

I'm still getting the error with pkgdown::build_site(), but everything else, including running the .Rmd checks out. It's running again right now after merging an update.

[bms63]

I'm still getting the error with pkgdown::build_site(), but everything else, including running the .Rmd checks out. It's running again right now after merging an update.

I will see if I can build site on my end

[bms63]

I was able to build website - I will review PR. @manciniedoardo can you also help with review please.

[manciniedoardo]

@ProfessorP-beep sorry, would it be possible to please update the occasions where we have exprs(get_admiral_option("subject_keys") to just say get_admiral_option("subject_keys")? I believe that would be the right syntax. thanks

[ProfessorP-beep]

@manciniedoardo Already done. I realized my mistake after that last push. New one coming as soon as the checks are done.

[ProfessorP-beep]

Sorry, hold off on reviewing on minute. Some of the changes weren't pushed through.

[ProfessorP-beep]

Hey @manciniedoardo, sorry about that. The latest pull is ready for review.

[rossfarrugia]

@bms63 any user could hardcode the subject identifiers instead if they were only ever going to use STUDYID, USBUJID here, but for our package to follow our own instructions at https://pharmaverse.github.io/admiral/reference/#admiral-options we have to follow the more generic way, otherwise an option that we ourselves advertise for users doesn't actually consistently work across the package.

[bms63]

@bms63 any user could hardcode the subject identifiers instead if they were only ever going to use STUDYID, USBUJID here, but for our package to follow our own instructions at https://pharmaverse.github.io/admiral/reference/#admiral-options we have to follow the more generic way, otherwise an option that we ourselves advertise for users doesn't actually consistently work across the package.

Okay! I understand how options work :) I feel like I'm not making myself very clear with my concerns...so maybe my concerns for the users is moot! :) If you all think this update makes sense for the users, then full steam ahead!!

[bms63]

and thanks @ProfessorP-beep for seeing this through!! This is how it works on the team :) We do PRs and I get a little huffy and puffy and ask funny questions - which usually are me being paranoid.

[rossfarrugia]

Thanks @bms63 - all fair questions, but i guess these all would have been discussed when we first added this option. Now that we have it offered in the package, we just need to make sure it works :)

[ProfessorP-beep]

and thanks @ProfessorP-beep for seeing this through!! This is how it works on the team :) We do PRs and I get a little huffy and puffy and ask funny questions - which usually are me being paranoid.

No problem! I'm also learning a lot more so this is cool. I'm looking through the discussion now.

[bms63]

@bundfussr @rossfarrugia @manciniedoardo - This update isn't critical to me for 1.1. Can we implement for 1.2 as it is actually quite large and seems to be opening lots of questions?

[manciniedoardo]

@bundfussr @rossfarrugia @manciniedoardo - This update isn't critical to me for 1.1. Can we implement for 1.2 as it is actually quite large and seems to be opening lots of questions?

Ok, let's leave until 1.2 to ensure we do this right and don't have to come back to it later. I still think it's an important update to make, and we can definitely still leverage all the work done by @ProfessorP-beep in this PR, but what we have now is not wrong per se, just a bit inconsistent.

[bms63]

Hi @ProfessorP-beep, we can talk about this tomorrow, but going to pause on this PR until after we ship 1.1 release. This will be our first PR into 1.2!

[ProfessorP-beep]

Hi @ProfessorP-beep, we can talk about this tomorrow, but going to pause on this PR until after we ship 1.1 release. This will be our first PR into 1.2!

Sounds good, I'm just gonna push the additional changes I've done since then. There is probably still some review to be done to make sure all cases are addressed.

[github-actions[bot]]

This Pull Request is stale because it has not been worked on in 15 days.

[github-actions[bot]]

This Pull Request is stale because it has not been worked on in 15 days.