Bryan Mishkin

Results 123 issues of Bryan Mishkin

Fixes #182. Based on: * https://github.com/bmish/eslint-doc-generator/blob/e9594090e38a4a2e71e56ba0588a5c223435cd5f/test/lib/cli-test.ts

internal

There are currently no tests for the CLI code in this file: ``` bin/check-dependency-version-consistency.ts ``` Possible approaches: * https://fireflysemantics.medium.com/unit-testing-commander-scripts-with-jest-bc32465709d6 * https://github.com/bmish/eslint-doc-generator/blob/dd2449aab1980ae1ed61401c04d87c66f0e96b98/test/lib/cli-test.ts#L108

internal

Values for duplicate object keys as seen in package.json comments are lost during autofix. Before an autofix to package.json: ```json { "dependencies": { "//": "comment about foo", "foo": "^1.2.3", "//":...

bug

It might be easier to only consider patch/minor version inconsistencies first since these shouldn't have breaking changes. One may want to consider/fix major version inconsistencies separately. Possible APIs: * `--ignore-semver...

enhancement

In resolutions, it's more common to use `>` or `>=` ranges to ensure a dependency is above a particular (especially vulnerable) version. Example: `package.json`: ```json { "workspaces": ["*"], "resolutions": {...

bug

Try this tool out with various public monorepos and see if we encounter issues: * [jest](https://github.com/facebook/jest) * many version inconsistencies with `*` and `workspace:*`

Use the type defined by https://www.npmjs.com/package/semver And improve variable/function naming.

internal

Double-check that the behavior is correct. ```json { "name": "foo", "dependencies": { "foo": "file:./" } } ``` Example, an ESLint plugin that has a dependency on itself so that it...

bug

To go along with the `--fix` option, we could have another option to specify how fixing is performed. | `--fix-strategy` | Behavior | | --- | --- | | `latest`...

enhancement

Attempt to fix #523 fix #522 fix #510. TODO: need to figure out how to stub `EOL` as `\n` in all the tests.

bug