Bryan Mishkin

Add TypeScript type-checking to all rules

2

We don't need to convert our JavaScript files to TypeScript, but by adding JSDoc comments with types and using the TypeScript [checkJs](https://www.typescriptlang.org/tsconfig#checkJs) option, we can get the benefits of type-checking....

New Rule: `no-invalid-names`

1

Disallow unwanted module/test string names. * No leading/trailing spaces (autofixable) * No empty strings * No missing name ([ava/test-title](https://github.com/avajs/eslint-plugin-ava/blob/main/docs/rules/test-title.md)) * No non-string values (numbers, objects, etc) * No strings starting/ending...

`no-identical-names` rule false positives with modules inside separate scopes/functions

1

This should be an valid case (but is currently invalid): ```js function sharedBehavior() { module('moduleName', function () {}); } module('moduleName', function () {}); // This is erroneously considered a violation....

New Rule: `no-assert-unexpected-type`

4

I've put together a quick/rough list of what argument data type checks we could add to each [qunit assertion](https://api.qunitjs.com/assert/). Feel free to comment with additional suggestions/corrections. I do think we...

Catch arrow functions for modules

6

Should the [qunit/no-arrow-tests](https://github.com/platinumazure/eslint-plugin-qunit/blob/master/docs/rules/no-arrow-tests.md) rule also catch modules with arrow functions? Or should we have a new separate rule `no-arrow-modules`? Bad: ```js module('my module', (hooks) => { // ... }); ```...

[no-loose-assertions](https://github.com/platinumazure/eslint-plugin-qunit/blob/master/docs/rules/no-loose-assertions.md) idea: The automatic suggestions from [no-assert-equal](https://github.com/platinumazure/eslint-plugin-qunit/blob/master/docs/rules/no-assert-equal.md) need to be ported over to it. _Originally posted by @bmish in https://github.com/platinumazure/eslint-plugin-qunit/issues/201#issuecomment-905555826_

Bug in [no-loose-assertions](https://github.com/platinumazure/eslint-plugin-qunit/blob/master/docs/rules/no-loose-assertions.md). It doesn't properly handle globals (similar to #132). _Originally posted by @bmish in https://github.com/platinumazure/eslint-plugin-qunit/issues/201#issuecomment-905555826_

I noticed some test cases commented out in the [tests](https://github.com/platinumazure/eslint-plugin-qunit/blob/master/tests/lib/rules/no-qunit-start-in-tests.js#L66) for [no-qunit-start-in-tests](https://github.com/platinumazure/eslint-plugin-qunit/blob/master/docs/rules/no-qunit-start-in-tests.md). ``` // Module hooks (new-style modules) /* Enable when supported { code: "QUnit.module(\"module\", function(hooks) { hooks.beforeEach(function() { QUnit.start();...

Add deprecation notice to README

1

Using the ember-cli linting plugins has been deprecated for years based on the RFC linked to below. ember-cli-eslint and ember-cli-template-lint have already been marked deprecated and have deprecation notices in...

Extending multiple configs can cause conflicts

1

Let's say a consumer extends two of our configs like this: ``` extends: ['plugin:square/ember', 'plugin:square/typescript'] ``` Here's an example of a problem that can happen: 1. `ember` config loads which...