Bryan Mishkin

Results 137 issues of Bryan Mishkin

#### Prerequisites checklist - [x] I have read the [contributing guidelines](https://github.com/eslint/eslint/blob/HEAD/CONTRIBUTING.md). #### What is the purpose of this pull request? (put an "X" next to an item) [ ] Documentation...

triage
breaking
feature

#### Prerequisites checklist - [x] I have read the [contributing guidelines](https://github.com/eslint/eslint/blob/HEAD/CONTRIBUTING.md). #### What is the purpose of this pull request? (put an "X" next to an item) [ ] Documentation...

core
accepted
feature

**The version of ESLint you are using.** Latest, 7.3.0. **The problem you want to solve.** ESLint rules can have complex schemas. Some schemas can reach 100 lines long, and often...

enhancement
core
accepted

### ESLint version 8.0.0-rc.0 ### What problem do you want to solve? * Currently, it's easy to forget to assert what suggestions a test case yields, or that a test...

enhancement
core
accepted
breaking

`languageOptions` has replaced `parserOptions` in flat config. But we can keep them both side-by-side in our ordered list of test case properties so that we can support both kinds of...

BREAKING CHANGE

The [no-deprecated-context-methods](https://github.com/eslint-community/eslint-plugin-eslint-plugin/blob/main/docs/rules/no-deprecated-context-methods.md) could catch additional methods: * `getAncestors()` -> `SourceCode#getAncestors(node)` * `getDeclaredVariables()` -> `SourceCode#getDeclaredVariables(node)` * `getScope()` -> `SourceCode#getScope(node)` * `markVariableAsUsed(name)` -> `SourceCode#markVariableAsUsed(name, node)` There's also a property we could catch:...

accepted
BREAKING CHANGE

The `deprecated`, `replacedBy` rule metadata properties were mentioned in the rule doc but not actually enforced by the rule. I have inserted these properties into the default list right after...

BREAKING CHANGE

As seen [here](https://github.com/eslint/eslint/blob/173e82040895ad53b2d9940bfb3fb67a0478f00b/tools/config-rule.js#L296), the deprecated/function-style format of ESLint rules can actually export `deprecated` and `schema` properties, and we should ensure that [eslint-plugin/prefer-object-rule](https://github.com/eslint-community/eslint-plugin-eslint-plugin/blob/main/docs/rules/prefer-object-rule.md) ports those over to the `meta` object when...

bug

We don't need to convert our JavaScript files to TypeScript, but by adding JSDoc comments with types and using the TypeScript [checkJs](https://www.typescriptlang.org/tsconfig#checkJs) option, we can get the benefits of type-checking....

javascript

I built this CLI tool [eslint-doc-generator](https://github.com/bmish/eslint-doc-generator) for automating the generation of the README rules list table and rule doc title/notices for ESLint plugins. It follows common documentation conventions from this...