Bryan Mishkin

Results 123 issues of Bryan Mishkin

See this comment: * https://github.com/ember-cli/eslint-plugin-ember/pull/1871/files#r1199802635

Bug

Came up here: https://github.com/ef4/ember-data-relationship-tracker/pull/25#pullrequestreview-1299859878 Could be added to: [ember/require-super-in-lifecycle-hooks](https://github.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/require-super-in-lifecycle-hooks.md) Related: * https://github.com/ember-cli/eslint-plugin-ember/pull/1294

Enhancement
New Rule

We don't need to convert our JavaScript files to TypeScript, but by adding JSDoc comments with types and using the TypeScript [checkJs](https://www.typescriptlang.org/tsconfig#checkJs) option, we can get the benefits of type-checking....

Internal

[eslint-doc-generator](https://github.com/bmish/eslint-doc-generator) is a CLI tool I built for automating the generation of the README rules list table and rule doc title/notices for ESLint plugins. It follows common documentation conventions from...

### Planned changes for v6 * #3023 * #3031 * #3029 * #2729 * #2913 TODO: * Update all dependencies * #3013 ### Future changes not yet ready: * Match...

breaking

The ESLint language plugin proposal was only just released: https://github.com/eslint/rfcs/pull/99 But matching ESLint's behavior/functionality has been one of our long-term goals, and a direction we've been moving in for a...

enhancement
breaking

`` is flagged as a violation of [no-duplicate-landmark-elements](https://github.com/ember-template-lint/ember-template-lint/blob/master/docs/rule/no-duplicate-landmark-elements.md) in this example: ```hbs {{#if @someVariable}} foo {{else}} bar {{/if}} ``` I know that `` could be moved outside the if statement...

bug

It's hard to find all of our documentation from the README. We should likely link to some more key docs from the README. And improve the organization of the README...

documentation