Bjorn Lu

Results 767 comments of Bjorn Lu

I don't think we need to do that for all the links in markdown, I was thinking updating it for the navbar is enough. It should require https://github.com/vuejs/vitepress/blob/179ee621d99b3c14e2e098e3b786465cbeaeab9a/src/client/theme-default/components/VPNavBarTranslations.vue to pass...

You can override it https://github.com/vuejs/vitepress/blob/5e0d7dab832044d89c8610b9800172d37e6201e7/src/client/theme-default/components/VPLink.vue#L32

Then, introduce a new option for VPLink to force mark internal? There's a lot of ways around it that you can explore. Maybe fixing the external check globally within VitePress...

> Nay, I'm experiencing this on a 3 million line app. > > I have not experienced this in small projects I know you're active in open source, but this...

Got some time to look at the repro and I can see it's also slower for me. Not sure if it matters for your app, but you should use `optimizeDeps.entries:...

I'm not sure what's the usecase for inlining workers yet, but I like the option with `config.build.assetsInlineLimit` since it reuses an existing config option. The naming could be a bit...

PR template: > What is this PR solving? Write a clear and concise description. This is just a one-line change. We do not need some AI-generated description. Also, have you...

We should have something like https://github.com/vitejs/vite/blob/63b82f1e29a00d06a82144fd03ea8d6eff114290/packages/vite/src/node/plugins/asset.ts#L452-L453 but it might not be kicking in somehow.

I suppose this is related to https://github.com/vitejs/vite/pull/10555. There's a perf concern if we run all Vite plugins for CSS resolving.