Bjorn Lu

Results 767 comments of Bjorn Lu

Hey, thanks for the PR. However this is a bit difficult for me to review as a lot of changes are made at once. I understand it's a bit cumbersome,...

Can you show how that it doesn't stream? If I add a log here https://github.com/bluwy/create-vite-extra/blob/8ae5c7449f6b329cbce9339834f6f6115d0110cf/template-ssr-react-streaming/server.js#L68-L73 I can see that there's two chunks being streamed here. The Suspense fallback probably isn't...

Hmm I seem to be able to replicate the issue now. If I add a long interval in `React.lazy()`, I can see that the server-side is waiting on that before...

This should be fixed now in v4.0.1

Feel free to send PRs to fix this. I currently don't have the bandwidth to investigate but will help review.

Yeah I think this is a good addition 👍 I had it only running when a top-level types is specified, and only for `exports["."]` as during the first implementation I...

> but it has a peerDependency with @types/node: 20 and 22 but not 24 Can you show where or which package is causing this? I don't see our `package.json` limiting...

Is this something that affects your project? Or only something you've noticed in our CI

> @bluwy Did you try with cache or without cache (delete `.eslintcache`)? I was testing without cache. With cache, there's not much improvement for me, maybe 50ms faster at most.

If anyone would like to take a **proper** crack at this, it's worth checking if it can be fixed in VitePress directly as other docs site may benefit from this...