Bjorn Lu

Results 767 comments of Bjorn Lu

I can confirm this too. I had always assumed this to be intentional since prebundling is always necessary for third-party libraries. Or it would cause the duplication issue as mentioned....

We also had the same singleton issue for Svelte as well. The solution was to force `optimizeDeps.include` on `svelte`, so the prebundled code essentially deduped it. I think the code...

I can't seem to reproduce this. I added a test and it preprocesses correctly: https://github.com/bluwy/svelte-preprocess-import-assets/commit/6208c3958ea5163f4ad6405b1a061cb55690cdf1. Maybe you can show the code where you have the `media-player` tag, or a github...

@kevinfarrugia can you explain why circular dependencies isn't desired here? In practice, Rollup is able to analyze if a chunk was already loaded before and reuse some imports from it...

Thanks for tracking the list! I'll try to respond to a set of items that I agree / prefer-not-to below: For "CI files" and "Misc", I think all of them...

Additionally maybe some files here should be checked: ![image](https://github.com/user-attachments/assets/a2cc26d3-ad84-4cc2-9c37-f6c44ab04631)

If you paste the original example in https://live-astro-compiler.vercel.app, you can see it's generated as (formatted for readability): ```js const items = [{ id: '1' }, { id: '2' }, {...

Deno has a Vite plugin that supports this: https://github.com/denoland/deno-vite-plugin. I'm not sure about the commonjs part but in any case it doesn't seem like something Vite-specific and would be handled...