Bjorn Lu comments

Results 767 comments of


                                            Bjorn Lu

Popper.js:9 Uncaught TypeError: styled_default is not a function

This may likely be a Vite bug (or esbuild) as well. If anyone can reproduce this issue and provide a repo or stackblitz, that would be really helpful here and...

Tests are failing after updating to Vite 4.1.0

Yeah the Vite PR change is intentional as it was previously incorrect (though many tooling relied on it). If setting `browser` condition doesn't cause any other issues, I think it's...

Tests are failing after updating to Vite 4.1.0

I guess it needs to be: ```js export default defineConfig({ test: { alias: [ { find: /^svelte$/, replacement: "svelte/internal" } ] } }) ``` to be more accurate.

REPL: Events defined with addEventListener() are not undefined after quick update, thus making them duplicate

Similar #146

Vite does not load proper build (server) on ssr webworker build

Also related: https://github.com/solidjs/solid-start/issues/263

fix(hmr): normalize the path info

Yeah I'm not really sure if there's a significant benefit for that. We also use `path.relative` without normalizing in a few places, and I think the pattern is that if...

create-svelte TypeScript project should use vite.config.ts instead of vite.config.js

I think it makes sense to use `vite.config.ts` if they chose TypeScript. There isn't a big difference with how Vite handles it if it's using `.js` instead.

"Reference Error: Cannot access uninitialized variable" in Safari on MacOS

Looks like a webkit bug: https://bugs.webkit.org/show_bug.cgi?id=242740. I'm able to reproduce this with only: ```ts export let bar = 'foo' await 0 ```

Add ability to disable Node polyfills

> For reference, Node 18 has been available since April, 2022. However, [AWS Lambda does not yet support Node 18](https://github.com/aws/aws-lambda-base-images/issues/47). Based on past history, it usually takes them about a...

feat(legacy): support iife output and merge polyfills with code

This was discussed in the last meeting. However we decided to not go ahead with this as we prefer to maintain the systemjs only version instead. If you'd like to...