Bjorn Lu

Results 767 comments of Bjorn Lu

There really isn't a way to simply fix this as explained in https://github.com/vitejs/vite/issues/6773#issuecomment-1308048405. The way bundlers work without a runtime proxy module loader means it would always have this hash...

> @bluwy can I ask how high this possibility is? Is it something closer to "yeah, maybe, after we solve 1000 of other more important issues" or to "that's indeed...

Closing this for now. The changes can be done in another PR that upgrades Starlight instead.

I can't seem to find the issue, but I remember suggesting supporting `` for something like this. Another way is to ignore this if specified in `build.rollupOptions.external` (but that sounds...

It's transformed to an import as Vite sees that it could be resolved to something else. See https://github.com/vitejs/vite/blob/ce790c4080b6592ed60edfcf90a9ec344d575fa1/packages/vite/src/node/plugins/html.ts#L356-L359 and https://github.com/vitejs/vite/blob/ce790c4080b6592ed60edfcf90a9ec344d575fa1/packages/vite/src/node/plugins/html.ts#L227-L231 Perhaps something Vite could do is try to resolve the...

I also wonder if the order matters: https://github.com/vitejs/vite/blob/d402ad3ae2b724fde7702eb255af502db7ca94d4/packages/vite/src/node/server/index.ts#L284-L288 say if we move the user-specified ones at the top before `**/node_modules/**` 🤔

Took a look at this one today. Seems to be tricky to fix. The place where we're removing the script tag is here. https://github.com/vitejs/vite/blob/a30a5489ccac56ec668546af840984367c356a38/packages/vite/src/node/plugins/html.ts#L295 This line naively remove the script...

The `extensions` option is intentionally undocumented since it's not ready for public use, unlike SSR which is more on the stable side (though still experimental). I think prebundling styles is...