Ran Benita

Results 431 comments of Ran Benita

@sliwinski-milosz Do you think you could create a reduced benchmark that you can share? I don't remember all of the details of these commits, but according to the commit messages...

The minimal reproduction is: ```py # test_it.py import pytest pytest.skip("skipping cli test (deps not installed)", allow_module_level=True) ``` ```py # conftest.py import pytest def pytest_collectstart(collector): if type(collector) is pytest.Module: collector.obj ```...

Hi, `pytest -c configs/conftest.py -c configs/pytest.ini` doesn't work, there can only be one config file, and a conftest file is not a config file in any case. So remove the...

This is not much to go on, you will need to provide us with some way to reproduce the issue.

> @bluetech this is a new feature, but given it is isolated I think we can release this in 8.0, do you agree? At this point I think it's better...

@henrylhtsang Your segfault seems to happen inside the "torch" library. Generally pytest is pure python code so if there's a segfault the problem is always someplace else.

pytest uses `unittest.TestCase.run()` to actually execute the test. Unfortunately, `run()` does the entire `setUp`/call/`tearDown` sequence, so pytest has no way to distinguish the phases. It's possible for pytest to implement...

> I understand this is not standard according to the PEP-552 (I haven't read it, just gleaming it from the discussion here), but deviating from it will somehow turn the...

@jgersti Only had a quick look now at lazy-fixtures, I do think this will break (after the change is done fully): https://github.com/TvoroG/pytest-lazy-fixture/blob/18ec85edb5e27c933733f748c685b2fd083198d7/pytest_lazyfixture.py#L50-L54 That's assuming `is_lazy_fixture` can be true for transitive...

> If assignments into funcargs will still be allowed everything should continue to work as before. It will, at least this PR won't change that. But can you explain how...