Ran Benita
Ran Benita
Looks like a similar problem to #12263, as seen here: https://github.com/pytorch/pytorch/blob/f1d1e3246f3203a4c9641fcda28b0ed66eb8f4d4/torch/testing/_internal/common_distributed.py#L547 The fix in pytorch would be similar to the one shown here for tornado: https://github.com/tornadoweb/tornado/pull/3374
`-1073741819` in Windows is "access violation" AKA "segmentation fault". pytest itself, written in pure Python, cannot trigger such a thing. You need to run the program under a (C) debugger...
Thanks the report, I will look into it.
- Regressed in 1a5e0eb71d2af0ad113ccd9ee596c7d724d7a4b6 - That commit [relies](https://github.com/pytest-dev/pytest/blob/127a372928cb68e2023ae3c6f8b407c4d2f1f2f7/src/_pytest/unittest.py#L69-L75) on a feature of `unittest.TestCase` where initializing it with the default `methodName="runTest"` is [treated specially](https://github.com/python/cpython/blob/51aefc5bf907ddffaaf083ded0de773adcdf08c8/Lib/unittest/case.py#L419-L426), allowing to instantiate even without `runTest` method...
Some projects (like mine) use a common base `TestCase` class. If you do this, you can work around this issue by adding a dummy `runTest` method, like this: ```py class...
I agree that the problem described in the issue is worth solving. To me the original idea of passing the exception(s) to `pytest_fixture_post_finalizer` seems better than adding a new `pytest_fixture_teardown`...
> Hey hello!, i think is handled, all additions are made with respect to -1. If -2 doesn't use -3, it will never be considered. I updated the tests with...
> As i understand the function self.getfixturedefs gives us the fixtures that the node depends on, in this case the two main defined at class and module level (the one...
Thanks for the update. Now there is a different problem. The code handles the case of `test -> foo -> foo -> bar` (correctly including `bar`), but doesn't handle `test...
Thanks, this does look wrong at first glance, I will look into it. Bisected to 09b78737a5bde23eb488d5d6649bf966c5809176 (PR #11220).