David Arnold
David Arnold
You'd also want to include https://github.com/frappe/frappe/pull/27801/commits/5c12091385d8f91db4e50735caf5a9addba7ef40 as of now, thanks to the report of a fellow frappe user.
@ruthra-kumar I added a unit test case for the fix and would go ahead with this as long as you don't have any objections.
@deepeshgarg007 @ruthra-kumar are you sure you're not interested in this fix and want to let it go stale?
> unrelated changes in 6bfefd2 Well, without them, I can't properly work on json files without forced reformatting and introducing unnecessary diff. `.editorconfig` is misconfigured and others would be affected...
@ruthra-kumar Could you help me understand how to fix the test so that I can run it individually? (it seems to be missing some generic test data) ```console ❯ bench...
@ruthra-kumar I finally found the time to perfect the test. This is ready to ship. I'll stand by for any in-adverted consequences, should there be any.
Thanks Ruthra, that was just a fat finger of mine. :smile:
Works even better with: - https://github.com/frappe/frappe/pull/26752
@barredterra I implemented this with yet another strategy, clarifying the contrived python implementation to prevent future developers from misunderstanding the JavaScript code. The performance goal is now achieved through loading...
@barredterra Could you revise your request for changes to this PR? Otherwise, it's ready and I am to own it and stand by for any potential consequences not covered by...