David Arnold
David Arnold
> An invincible determination can accomplish almost anything and in this lies the great distinction between great men and little men. - Thomas Fuller --- Kindly help move this PR...
@akhilnarang @surajshetty3416 I'd want to proceed to merge and own this, if you havn't got any objections. Maybe there's someone on the team who should have a look at this,...
Note to self, before moving ahead: Flip the switch on the client side for dev servers according to [this comment](https://github.com/frappe/frappe/pull/26752#issuecomment-2314447857) (last paragraph) so that `Cache-Control` is made ineffective (yet still...
@akhilnarang Since no notification about potential problems with https://github.com/frappe/frappe/pull/26752 have reached me in the last 2 weeks since its merge, I'd proceed cautiously with this one, next. I'm running this...
@ruthra-kumar, this depends on the merge of [PR #26891](https://github.com/frappe/frappe/pull/26891). This implementation ensures consistent end-to-end marketing tracking via UTM (Urchin Tracking Module). For instance, if an inbound UTM specifies `?utm_campaign=foo&utm_source=fb&utm_medium=display`, all...
I don't know. But this PR needs an upstream merge anyways, first. So I'm not worried about tests, atm. Iirc, they were all passing.
I'm putting this on auto-merge cause the upstream change is likely to break master, due to a (now) stale doctype reference. I've run this in production for 3 months now...
@mudux acked, on it. Thanks for the report! Is there a way I can reach out on telegram if need be?
Can you execute these steps: - Update frappe at the same time? (`UTM Source` is a **new** frappe website doctype) - If that does not work: - Update frappe first?...
@mudux please quickly confirm for clarity in posterity: where you able to solve the issue by updating frappe at the same time? Thx