David Arnold

icon location Munich icon location I'm an enthusiast. Who's not?

Results 1203 comments of David Arnold

fix: loyalty points application on si

I removed my comments above: I didn't understand them anymore myself.

fix: loyalty points application on si

@ruthra-kumar can you help me understand what (on earth) is (re-)setting `si.loyalty_program` to `None` on `si.insert()`? In production, we get it from the customer, but here I didn't bother to...

perf: flush db at once

ping

perf: flush db at once

@ruthra-kumar this is green now on its own.

perf: flush db at once

> Go for it now. The future is promised to no one. - Wayne Dyer --- Kindly help move this PR forward. Many thanks from Yours Sincerely!

fix: spec mobile and email fields for notifications

ping

fix: spec mobile and email fields for notifications

@ruthra-kumar An easy one :smile: context: https://github.com/frappe/frappe/pull/24725, specifically: - https://github.com/frappe/frappe/pull/24725/files#diff-a2945bf21739af1497474a3e0c35cb846f6f99b5b678880e461f341b751ef1d3R87 - https://github.com/frappe/frappe/pull/24725/files#diff-a2945bf21739af1497474a3e0c35cb846f6f99b5b678880e461f341b751ef1d3R91

fix: spec mobile and email fields for notifications

@Mergifyio backport version-15-hotfix

fix: spec mobile and email fields for notifications

Data fields are detected for eligibility in notifications based on the value of the Option field. E.g.: - `Email` -> eligible for email notificación - `Phone` / `Mobile` -> eligible...

fix: spec mobile and email fields for notifications

This was already the case (eg. for `Phone` / `Mobile`) prior to https://github.com/frappe/frappe/pull/24725 but is there augmented further.