Brandon Keepers

Results 93 comments of Brandon Keepers

See the note on https://github.com/bkeepers/dotenv#rails > [dotenv] should be listed in the Gemfile before any other gems that use environment variables, otherwise those gems will get initialized with the wrong...

@stevenharman thanks for the pull request! Sorry it took so long to review.

I'm going to hold off on this for now since we're not using this adapter in production. Eventually I do think some kind of interval-based memoization (instead of request-based) will...

> Looking at it, it only works as hierarchy and when using the lowest level. But if you check from higher levels you'll have to really know what's going on....

@limjinsun can you give more information? Can you share the stack trace? What version of rails? What does the relevant routes config look like?

@j-castellanos Thanks for the PR! In https://github.com/flippercloud/flipper/pull/826#pullrequestreview-1832444441 I offered a couple suggestions of how I think we should approach connection pool support. I don't really love having different adapters Redis...

> Any best practices on how to make this more "templatized"? Sadly, no. This has actually been common problem with testing Probot plugins. There is so much data in the...

Nicely done. I'm not actually sold on jasmine-given. I think it's a really interesting idea, but I don't love it. It doesn't feel to me like it adds clarity. Want...

Yeah. I think it should just be a manually created view. I was going to try to make it all auto-magic, but it's a PITA.

I've found it a little confusing too. I like that it polls for new ones, but I agree that I find it odd that the old ones don't go away....