Bastian Köcher

Results 756 comments of Bastian Köcher

I'm still not convinced that this is a good idea. The problem I'm seeing here is that over different wasmtime version, the same wasm file could have a different stack...

We also have these checks inside the runtime: https://github.com/paritytech/substrate/blob/master/frame/babe/src/lib.rs#L866-L869 To ensure that timestamp and slot are matching.

> The question is, why would the state be discarded thinking Is the queried block a fork that is behind the finalized block? If yes, this is your reason why...

@dmitry-markin and @altonen could both of you please both look into this?

I thought about this already since quite some time. Aka that this `_context` and `at` parameter were not my best idea. I also thought that we should do a builder...

You would need to change the syntax to make this more obvious. However, I don't have any idea about a good syntax.

> I think the main block in turning a lot of the FRAME primitives to builders patters (which are arguably a lot nicer) is the over-use of **types**. Everything in...

> `impl-serde` 0.3.2 added support for deserializing without `0x` prefix: [paritytech/parity-common#598](https://github.com/paritytech/parity-common/pull/598). This broke the test. Should I change the test? Or this assumption is baked in other places? Looks reasonable...

@EclesioMeloJunior could you may provide a way to reproduce this?

Yeah my question was more on how to run gossamer to recreate this spam ;) Or at least to show the code and then @dmitry-markin could maybe adapt it to...