substrate icon indicating copy to clipboard operation
substrate copied to clipboard

update kvdb & co

Open ordian opened this issue 3 years ago • 3 comments

TODO: companion

ordian avatar Sep 20 '22 13:09 ordian

thread 'tests::should_parse_extrinsic_address' panicked at 'assertion failed: `(left == right)`
  left: `Ok(Bytes([18, 52]))`,
 right: `Err("Extrinsic index missing: example \"5:0\"")`', bin/node/inspect/src/lib.rs:299:9

doesn't seem to be related to the PR

EDIT: on the second thought it does...

ordian avatar Sep 20 '22 14:09 ordian

impl-serde 0.3.2 added support for deserializing without 0x prefix: https://github.com/paritytech/parity-common/pull/598. This broke the test. Should I change the test? Or this assumption is baked in other places?

ordian avatar Sep 20 '22 15:09 ordian

impl-serde 0.3.2 added support for deserializing without 0x prefix: paritytech/parity-common#598. This broke the test. Should I change the test? Or this assumption is baked in other places?

Looks reasonable to support without leading 0x as you have done it.

bkchr avatar Sep 20 '22 20:09 bkchr

bot merge

ordian avatar Oct 05 '22 21:10 ordian