Bastian Köcher
Bastian Köcher
Okay, yeah that is a lot of overhead. Looking at the code, it is not really that much different. It could be probably the `FnOnce` that kills us here?
Hey @hawkw, sorry for the long delay. I pushed some commits. Could you take a look please. I also run the benchmarks. Besides the `event::none` it looks good to me....
> @bkchr just to clarify, are change percentages in the benchmark results you posted in [#2165 (comment)](https://github.com/tokio-rs/tracing/pull/2165#issuecomment-1231420625) relative to `v0.1.x`, or to a previous state of this branch? They are...
Back, with your comments included @hawkw :) Now it also looks cleaner IMO. ``` comparison/relaxed_load time: [493.59 ps 494.46 ps 495.27 ps] change: [-0.3906% -0.1201% +0.1655%] (p = 0.40 >...
@hawkw would be nice if you could take a look when you have time
@dmitry-timofeev 1. Yeah every time you call `find_class`, it will use the global class loader if present. 2. Hmm, I'm not sure about surprising effects. It is also only used...
Ping @dmitry-timofeev
How should the class loader be garbage-collected, when we store an instance in a global reference?
I just use the com/example/Foo class names and that works.