🧪 add engines test
failing engines test before engines change with 0.6: https://github.com/jshttp/mime-types/actions/runs/14111833661/job/39532276468?pr=136
passing engines test after engines change to 18: https://github.com/jshttp/mime-types/actions/runs/14111854628/job/39532350886?pr=136
resolves #135
I don't fully understand your change. How does that fix the original problem? Are we going to release a new major version?
@bjohansebas as mentioned in the issue, we are not going to release a new major just for an engines change. what is your understanding of the "original problem"?
I'm okay with adding that step in the CI, but is the engine change going to be merged? That's what I don't understand.
@UlisesGascon yep! that's true.. this additional test is just to check if we missed updating the engines field, and not truly to validate that it works in the earliest possible supported release of node. we decided a while ago to unpin our CI so that runs will always use whatever GH fetches as the latest version of the major. technically, we would not know about any break in 18.0.0, 19.0.0, 20.0.0, etc. if we are concerned about that (and I don't think we are), we would want to address that in our regular CI job
@bjohansebas yes, the engine change is going to be merged