Vitalii Levitskii comments

Results 18 comments of


                                            Vitalii Levitskii

Yarpc v2 apis which provides compatibility with golang/protobuf v2.

Code migrated in separated diffs.

protoc-gen-yarpc-go always generates fx code

Generative code is complicated enough, I don't think we'll add `--no-fx` option in a near future.

use atomics for metrics

I also noticed this potential improvement, glad to see opened PR for this (: @swithek do you have any concerns regarding this improvement or regarding this particular PR?

Changed encoding/decoding error code to from InvalidArgument to Internal

I revisited code and tests, and revert changes for server decoding: those errors indeed indicates that client sends invalid request.

Bump golang.org/x/net from 0.0.0-20211015210444-4f30a5c0130f to 0.7.0

Bumped in #2258

Bump github.com/prometheus/client_golang from 1.4.1 to 1.11.1

Indirect dependency.

Bump golang.org/x/net from 0.0.0-20211015210444-4f30a5c0130f to 0.7.0 in /internal/crossdock

Bumped in #2258

Rename Size() method

Thanks for response! Yeah, I understand that at this point it's already impossible to rename this method. As for specialname, I tried to use it, it renames field in code...