yarpc-go icon indicating copy to clipboard operation
yarpc-go copied to clipboard

protoc-gen-yarpc-go always generates fx code

Open robbertvanginkel opened this issue 6 years ago • 2 comments

After https://github.com/yarpc/yarpc-go/pull/1449, protoc-gen-yarpc-go always generates code for go.uber.org/fx.

We should make the fx code generation optional to not force a dependency on fx when using yarpc. Either through an opt out like--no-fx or opt in like plugins=fx. Leaning towards the second as its similar as how the default go plugin allows you to also generate grpc code.

robbertvanginkel avatar Aug 15 '18 18:08 robbertvanginkel

We may need to use an opt-out to preserve backward compatibility.

akshayjshah avatar Aug 16 '18 22:08 akshayjshah

In #1449 we talked about adding a --no-fx later, I think this is what you'd want.

bufdev avatar Aug 21 '18 17:08 bufdev

Generative code is complicated enough, I don't think we'll add --no-fx option in a near future.

biosvs avatar Apr 15 '24 13:04 biosvs