Ben Firshman

Results 290 comments of Ben Firshman
trafficstars

I'll put it on the @orchardup S3 account and we can cover the cost. Shouldn't be much. :)

@jasikpark Arxiv Vanity maker here! Thanks for this, it looks great. A usability suggestion: the link should probably ave the text “HTML” or “Web” for those who don’t know what...

@karpathy What do you think? We get lots of requests for this from arXiv Vanity users. An email today reminded me of this issue...

Hm! Interesting. Honestly, I’ve never tested Node properly so it’d be nice to get this working and documented. Here is what I did in the tests: https://github.com/bfirsh/jsnes/blob/master/test/nes.spec.js Slight variation on...

Hm! Yes odd. Sounds like the test is broken in that case. It’d be nice to compare some frame output in the test to make sure it’s doing the right...

In addition, the stop() method doesn’t even exist any longer. All the same problem.

Boom, amazing thank you! I wonder if there is a way to add a simple test to this to ensure they stay in sync? No big deal if it's difficult.

Yeah, exactly. I wonder if there's a simple typescript lint or compile command that could run in CI, or something. Not a big deal if it's not simple.

Looks like the build is broken anyway, sigh. (It's also broken on master.)