Ben Firshman

Results 290 comments of Ben Firshman
trafficstars

Amazing thank you! This needs a bit of rebasing and cleaning up though. It depends a bit on your local Git setup, but try pulling from replicate/keepsake main, then cherry...

:+1: test failures are real. Would be great to get some tests for the problem you describe too, to validate that it has been fixed.

@Evarin Good catch -- fixed all this stuff. Thanks! I have also added a simple GitHub actions check that makes sure the package is importable after `pip install`. This will...

I have rebased this and fixed conflicts. @rromb @pesser @manolo-lolo does this look good? :)

Half fixed in 374f9263a3b6ae82aca7b81ec00622bf50999399 where it'll use the first key in the list.

Hmm. Maybe we could using Debian packages instead? There's probably a PPA that works across all of the Ubuntu versions.

Is there a way of pinning it in the Dockerfile? That way we can update it with a PR without having to deal with Docker Cloud's web UI. 😆

Rebuilt it in the meantime anyway!

👍 It'd also be neat to have a short description in `whalebrew search`.

Ah! Googling for this error, it looks like this is colliding with _another Cog_. 😂 https://github.com/Igalia/cog I should have mentioned in the original PR -- did you install (the machine...