Ben Firshman

Results 290 comments of Ben Firshman
trafficstars

Sounds great, thank you! This might uncover some bugs, too...

Some interesting discussion of graphics glitches (perhaps broken serialisation?) here: https://github.com/bfirsh/jsnes/issues/16

This was mostly done here: https://github.com/bfirsh/jsnes-web/pull/170 The only thing remaining is to release this (or jsnes-react?) as a package on npm.

Ah thank you! I’d say the original intention of this ticket is kinda done now, but I love your idea of taking it even further. :)

Sent to somebody interested in implementing this: > It’s called battery RAM, which you’ll see various references to in the code. I’d imagine it’d store it in local storage somewhere,...

Ah neat! Yeah not going to merge it, but I'll leave it open for people who are curious. :)

Awesome thank you! Testing the integration of the modal with the controllers is probably a good idea (I don’t think there is any testing for the custom keyboard commands) but...

No worries! There are a couple really simple ones - the files ending in `.test.js` in `src/`.

@tario Seems like the gamepad support is breaking non-webkit browsers too. This error is coming from IE: https://sentry.io/share/issue/b0c3a6b734294b30b6414c548d57a410/

Yes! Thanks for the suggestion. A simple solution would be to just format the JSON with newlines and indenting. Another alternative would be to have a YAML-like value, which might...