jsnes icon indicating copy to clipboard operation
jsnes copied to clipboard

Add types for exported module

Open darthgoldstein opened this issue 2 years ago • 6 comments

Added a few .d.ts files to describe the types of the exported modules for this project. Resolve Issue 412

darthgoldstein avatar Nov 24 '21 10:11 darthgoldstein

@bfirsh I'd really love it if you could take a quick look and give me feedback or merge this change :)

darthgoldstein avatar Dec 01 '21 09:12 darthgoldstein

Boom, amazing thank you! I wonder if there is a way to add a simple test to this to ensure they stay in sync? No big deal if it's difficult.

bfirsh avatar Dec 01 '21 15:12 bfirsh

That the types stay in sync with the actual classes that they represent?

darthgoldstein avatar Dec 07 '21 09:12 darthgoldstein

Yeah, exactly. I wonder if there's a simple typescript lint or compile command that could run in CI, or something. Not a big deal if it's not simple.

bfirsh avatar Dec 07 '21 17:12 bfirsh

Looks like the build is broken anyway, sigh. (It's also broken on master.)

bfirsh avatar Dec 07 '21 17:12 bfirsh

Looks like the build is broken anyway, sigh. (It's also broken on master.)

Well that's no fun. I just uploaded #415 which should ideally fix the build issue.

darthgoldstein avatar Dec 09 '21 16:12 darthgoldstein