Thomas Beutlich

Results 394 comments of Thomas Beutlich

Not sure if I found the right place to consider nominal values, but this quick-and-dirty change could work: ```diff --- a/Modelica_ResultCompare/CurveCompare/TubeSize.cs +++ b/Modelica_ResultCompare/CurveCompare/TubeSize.cs @@ -126,7 +126,7 @@ namespace CurveCompare {...

I am neither sure what "former" and "standard" refers to. When debugging, I noticed that the "former" function is called.

What I propose is to add an extra (and optional) row (explicitly marked by keyword "nominal") for the nominal values of each signal. For example: ```csv "time", "v1", "v2" 0.0,...

I see, it's only common to have one optional header record in CSV files (being non-standardized anyway), not more than one. Still I consider my proposal as convenient enough for...

As an idea: Should we refer to https://web.archive.org/web/20220930065028/https://modelica.org/licenses/modelica-3-clause-bsd ? But I did not like that the copyright year 2019 never got updated at all.

Issue is resolved. Thanks @t-sommer !

> The new version of MapleSim's moparser allows it. But I do not know how to upload it. The [github page for it](https://github.com/modelica-tools/ModelicaSyntaxChecker) was archived. I sent an email to...

Syntax checks still fail with MapleSim Stand-Alone Modelica Parser 3.6 (after branch rebase).

> what version of moparser is used for the checks MapleSim Stand-Alone Modelica Parser 3.6, see https://github.com/modelica/ModelicaStandardLibrary/actions/runs/6912730662/job/18808801660?pr=4231

> If you click on the triangle next to "Run echo "::add-matcher::./.github/moparser.json"" in [that link](https://github.com/modelica/ModelicaStandardLibrary/actions/runs/6912730662/job/18808801660?pr=4231), it looks like the version for `moparser` is explicitly set the version to 3.4: >...