Bert De Block

Results 231 comments of Bert De Block
trafficstars

@christianarty Thanks for the update. Yeah, I thought I'd just mention the `concurrently` issue just in case, but agreed, not in scope for this PR.

Going to close this one because of https://github.com/ember-learn/guidemaker-ember-template/pull/10#issuecomment-502692156.

@optikalefx Do you have time to address the comments?

I'm experiencing this issue as well. When overriding the `filesPath` hook the `options` argument that's being passed along equals to `undefined`.

Yes, this is still the case it seems. If you create a simple blueprint named `foo` and add the following: ```js filesPath(options) { console.log(options); return this._super.filesPath.apply(this, arguments); }, ``` and...

FYI, it seems the following issues are related (maybe the same?): - https://github.com/ember-cli/ember-cli/issues/8160 - https://github.com/ember-cli/ember-cli/issues/8866

Does this also include the use of `process.env.CI` in the app blueprint, and thus adding `ci-info` as a direct dependency for new Ember apps?

@BryanCrotaz I'm not able to reproduce this with a fresh v3.23 app. I could be missing something simple. Do you have a runnable reproduction?

Since `Route#renderTemplate` will be deprecated in Ember v3.27.0 and this issue is quite old, can we close it?