Bert De Block

Results 231 comments of Bert De Block
trafficstars

@tsamlink Could it be that you are using an older version of `ember-test-selectors` that maps `data-test` arguments to `data-test` attributes on the component's outer tag? I'm guessing that's it? Though...

@lifeart that could be an option, but kebab-case argument names are still valid I think. Ember's `LinkTo` component also has a `current-when` argument for example.

So it seems the [codemod](https://github.com/ember-codemods/ember-angle-brackets-codemod) also ignores `class` and `data-` arguments [here](https://github.com/ember-codemods/ember-angle-brackets-codemod/blob/6d79f9354623fc01179e94c18b453c1783c0ff96/transforms/angle-brackets/transform.js#L132-L137), so I guess it is okay to do so here as well? It is probably the desired outcome...

Sounds good 👍 Do you mind explaining how the fix is more predictable? Is the codemod outdated or something?

If we need to check if the button has a `form` parent, we could make [this function](https://github.com/ember-template-lint/ember-template-lint/blob/master/lib/rules/require-button-type.js#L10-L20) a shared helper and use that here as well? Though, if this rule...

AFAICT the only steps needed are: 1. The engine should have `ember-page-title` as a direct dependency (needed to have the `page-title` helper available) 2. Define a dependency on the `page-title-list`...

Can we include this as part of the v8 release? I don't think it's worth the time to introduce a deprecation for this. AFAICT, the only user change that's needed...

Is this in response to the [Replace terms blacklist & whitelist in Ember CLI](https://emberjs.github.io/rfcs/0639-replace-blacklist-whitelist.html) RFC? If so, I thought the settled upon terms were `include` and `exclude`? If not, please...

Maybe these can be ditched as well? https://github.com/adopted-ember-addons/ember-keyboard/blob/master/addon/index.js#L5-L15 They seem to have been present like this for a while, so seems safe to drop these in the next major?