Bert De Block

Results 231 comments of Bert De Block
trafficstars

I overlooked some tests, e.g. `ember help` output, will fix asap!

Can't seem to figure out why CI is failing at the moment. It seems this line is the culprit: https://github.com/ember-cli/ember-cli/blob/master/tests/acceptance/smoke-test-slow.js#L236-L237 It hangs, and thus the timeout is exceeded. Seems to...

Glad you're excited 😄 I just need to know what to do about https://github.com/ember-cli/ember-cli/pull/9824#discussion_r833591726.

Addressed the smaller issues, still need to come up with an acceptance test that completes the entire flow.

In case anyone is following along, I could use some help writing a full acceptance test where we simulate user input.

Anyone who can verify this change? Would be nice to get this in if this actually fixes an issue.

Does [this issue](https://github.com/ember-cli/ember-cli/issues/8969) still exist when using `yarn start`? If so, I'm not sure if we should use it instead of `ember s`?

An issue in the RFCs repo might be a good start?

@elwayman02 Are you still interested in pursuing this PR? Should we close if not?

There's more to it than just this PR though. Using the `ember` global is also what's used in the guides etc.