Bernhard Owen Josephus
Bernhard Owen Josephus
PR is ready cc: @akinwale
Requested in ND.
## Proposal ### Please re-state the problem that we are trying to solve in this issue. There are 2 OpenReport calls when open a thread that we never loaded yet....
In my root cause, I explained the unnecessary calls are coming from here, https://github.com/Expensify/App/blob/2987fc0562f2c83852b9df19f9cef36ecdf4d621/src/pages/home/ReportScreen.tsx#L582-L587 which I offer 2 solutions to solve it. Do you care to explain why you think...
That specifically happens after https://github.com/Expensify/App/pull/49056 where they add a check for the report here. https://github.com/Expensify/App/blob/f0be8a731dc0832827dbd14d23fd49b332ff275e/src/pages/home/ReportScreen.tsx#L169-L173 So, previously, even when the report is undefined, the reportID will still be an empty...
Why is it a workaround? The current code is the workaround for an issue that isn't happening anymore. https://github.com/Expensify/App/blob/96ffbfe27c5c1b85b062e6ab50c0adc46b0e94c3/src/pages/home/ReportScreen.tsx#L580-L586 I'm suggesting to revert back to the old condition which compares...
It's from this PR: https://github.com/Expensify/App/pull/15994
> Is it not happening anymore because of the workaround @bernhardoj ? i.e. if we removed the workaround would the issue resurface? Yes, it's not happening anymore from my testing...
@sobitneupane it's a different issue: https://github.com/Expensify/App/issues/53637 which is already reverted. I have merged with main.
I think there is still 2 things to fix on the BE. 1. Updating the category. When updating the category, the tax rate is updated optimistically, but the response from...