[$250] Thread – Unable to leave thread in a task detail.

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.0.5-3

Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4700550 Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: applause internal team Slack conversation:

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Log in
3. Open any chat
4. Send a message
5. Right click on the message and select Reply in thread
6. Send a message in a thread
7. Click on the header

Expected Result:

Leave thread option is present in a task detail

Actual Result:

Leave thread option is missing in a task detail

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [x] Android: Native
• [x] Android: mWeb Chrome
• [x] iOS: Native
• [ ] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

https://github.com/Expensify/App/assets/38435837/9932b490-414e-407b-bab1-4c9b11962dc7

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0186cdebe249073b07
• Upwork Job ID: 1810358159239707374
• Last Price Increase: 2024-07-08
• Automatic offers:
• akinwale | Reviewer | 103047193

Issue Owner

Current Issue Owner: @akinwale

[melvin-bot[bot]]

Triggered auto assignment to @puneetlath (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot[bot]]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions[bot]]

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[m-natarajan]

@abekkala FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[m-natarajan]

We think that this bug might be related to #vip-vsb

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

There is no option to leave thread in report details page.

What is the root cause of that problem?

The condition of showing the leave button requires the report to not be a thread. https://github.com/Expensify/App/blob/e0ccba51a40d67283b658aeffa3040fb2eb45795/src/pages/ReportDetailsPage.tsx#L243-L244

Previously, we had a 3-dot button that shows the leave option for the thread, but now it's removed, but the leave button condition isn't updated yet.

What changes do you think we should make in order to solve the problem?

I propose that we just use ReportUtils.canLeaveChat function to check whether we can leave a report or not. Then, we can move the other current conditions to canLeaveChat.

const shouldShowLeaveButton = ReportUtils.canLeaveChat(report, policy)

function canLeaveChat(report: OnyxEntry<Report>, policy: OnyxEntry<Policy>): boolean {
    if (isGroupChat) return true;
    if (isPolicyExpenseChat && !report.isOwnPolicyExpenseChat && !isPolicyAdmin) return true;
    ...

Last, we need to update the leaveChat logic so that leaving a thread will call leaveRoom instead of leaveGroupChat. https://github.com/Expensify/App/blob/e0ccba51a40d67283b658aeffa3040fb2eb45795/src/pages/ReportDetailsPage.tsx#L224-L232

We can do that by switching the check.

if (isGroupChat) {
    leaveGroupChat()
    return;
}
leaveRoom()

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~0186cdebe249073b07

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

[puneetlath]

I don't think this needs to block the deploy. Going to demote it and make it external.

[akinwale]

@bernhardoj's proposal works here.

🎀👀🎀 C+ reviewed.

[melvin-bot[bot]]

Current assignee @puneetlath is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot[bot]]

📣 @akinwale 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

[puneetlath]

Sounds good. I like consolidating the logic into ReportUtils.canLeaveChat.

[bernhardoj]

PR is ready

cc: @akinwale

[abekkala]

waiting on PR Review @akinwale

[melvin-bot[bot]]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot[bot]]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[abekkala]

deployed to production Jul 23

[akinwale]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [x] [@akinwale] The PR that introduced the bug has been identified. Link to the PR:
• [x] [@akinwale] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

This was a regression from https://github.com/Expensify/App/pull/44252.

• [x] [@akinwale] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [x] [@akinwale] Determine if we should create a regression test for this bug.
• [x] [@akinwale] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Steps

• Launch Expensify
• Open a chat report
• Send a message
• Reply in the thread of the message that was sent
• Click or tap on the chat header
• Verify that the Leave option is displayed in the menu

Do we agree 👍 or 👎?

[abekkala]

PAYMENT SUMMARY FOR JULY 30

• Fix: @bernhardoj [$250] payment via New Dot
• PR Review: @akinwale [$250] Offer

[abekkala]

@akinwale payment sent and contract ended - thank you!

[bernhardoj]

Requested in ND.

[JmillsExpensify]

$250 approved for @bernhardoj