Bernhard Owen Josephus

Results 361 comments of Bernhard Owen Josephus

Edited by **proposal-police**: This proposal was **edited** at 2024-11-28 02:32:31 UTC. ## Proposal ### Please re-state the problem that we are trying to solve in this issue. The total invoice...

It's explained here (invoice not included) https://github.com/Expensify/App/blob/4c47abedddbbdfb163faad81afcfbbcd84766f6e/src/libs/TransactionUtils/index.ts#L428-L449 I think we can create a util function in IOUUtils called `getNormalizedAmount`, but do we want to follow the logic above, that is...

Updated my proposal to include the util function. > as it seems that code is also wrong Which part of `TransactionUtils.getAmount` is wrong?

My first thought that it should be true for self DM track, but I just realized we can track expense in workspace too. It was added in https://github.com/Expensify/App/pull/38709, specifically this...

Yes, it's the `isFromTrackedExpense` param, but we have one usage of it on the IOU tax rate page. https://github.com/Expensify/App/blob/64eaf2fdd357bd06008adfb9c0c049e09cd375b9/src/pages/iou/request/step/IOURequestStepTaxRatePage.tsx#L65 From this [commit](https://github.com/Expensify/App/commit/228c47705cc4a06d8d0a343be222e8e952523039), previously we get the transaction amount by `transaction.amount`...

## Proposal ### Please re-state the problem that we are trying to solve in this issue. Enabled badge of the right component is not crossed out when deleting a tag...

## Proposal ### Please re-state the problem that we are trying to solve in this issue. Pressing Enter doesn't proceed the user to the next page in the limit amount...