Bernhard Owen Josephus
Bernhard Owen Josephus
PR is ready cc: @parasharrajat
## Proposal ### Please re-state the problem that we are trying to solve in this issue. Hold error message isn't prioritized to be displayed. ### What is the root cause...
> Last, we can "revert" https://github.com/Expensify/App/pull/45325 because we fix it differently here. > @bernhardoj Can you give a proper solution here? Sorry, I don't get what do you mean by...
This one The current condition looks like this: https://github.com/Expensify/App/blob/0a33186c80eb821d67d75b44bca527640204852c/src/components/ReportActionItem/MoneyRequestPreview/MoneyRequestPreviewContent.tsx#L194-L216 The solution will update it to: ``` if (shouldShowHoldMessage) return `${message} ${CONST.DOT_SEPARATOR} ${translate('violations.hold')}`; if (violations[0]) ... if (hasFieldErrors) ... ```
PR is ready cc: @shubham1206agra
## Proposal ### Please re-state the problem that we are trying to solve in this issue. There is no maximum line for the report description. ### What is the root...
@ishpaul777 sure, here is the [test branch](https://github.com/bernhardoj/Expensify/tree/fix/37357-report-description-max-line)
Oh, you're right. I only test it with plain text 🤦
## Proposal ### Please re-state the problem that we are trying to solve in this issue. Can't download a text file while uploading. ### What is the root cause of...
Edited by **proposal-police**: This proposal was **edited** at 2024-09-07 11:26:48 UTC. ## Proposal ### Please re-state the problem that we are trying to solve in this issue. Emoji category button...