Björn Rabenstein
Björn Rabenstein
I have reached the beginning of my (unplugged) vacations and didn't get to this. I'm very sorry for that. I'll try to find another reviewer (or will come back to...
@ArthurSens I assume you'll take care of the further review. Let me know if you need any help.
We are clearly both lacking time. Which in turn means we should try even harder to avoid redundant review work. Instead of a parallel review, one of us should do...
@ArthurSens is this still on your queue?
You should generally avoid naming a metric with a `_count` suffix. This suffix is a "magic" one that summaries and (classic) histograms auto-generate when ingested (or when represented in the...
If you just have sum + count, I would use a summary without quantiles. That's the most canonical way of representing it. If you want a histogram later, so be...
Ok, let's re-open then. This feels like an issue only affecting MS Windows. First of all, it would be good to know if more people are still seeing this. My...
That's a good point. If Prometheus needlessly opens these files in rw mode, we can easily fix that.
Closing this as per the discussion above. If MS Windows experts have concrete advice how we could improve the code on the Prometheus side without a ton of platform specific...
Not sure how available @bboreham is. I'll just merge this so we have it in ASAP.