Ben Vanik

Results 416 comments of Ben Vanik

fine with leaving it if it's useful - or can move it to users/stellaraccident - just wanted to make sure it wasn't dead :)

that test_utils.h is defining flags in the header - that's invalid - that means every file that includes the .h will define the flags. the header should expose some accessor...

This was broken in #16849 /cc @pashu123

Would be good cleanup! The style we hold is that iree_compiler can be omitted because all IREE code is in it, and then any dialect references require explicit specification (so...

Good point - sounds reasonable. But yeah, let's make the impl cleaner first before it gets too complex for anyone to reverse engineer and improve later on :)

Nah we don't want to use codegen for the reference - that prevents us from running the test on devices that may not have LLVM CPU support, etc and makes...

You're changing the ABI and inducing undefined behavior :) You cannot change the function interface after the dispatch has been formed. A flow.dispatch *must* be consistent with the target of...

(the technical detail here is that ROCM takes all buffers and other arguments as a packed struct, and if you change the order/counts of any input that struct layout changes...

Not sure I'm following. The rule is: the dispatch and the dispatchee must match exactly. Making that true can be tricky when mixing layers of the stack (stream and flow...

Reopening in case you find the issue - I'm not clear what's happening and would need more information.