Enable pkgci asserts

Open stellaraccident opened this issue 1 year ago • 4 comments

Apr 02 '24 01:04 stellaraccident

@ScottTodd still useful?

May 13 '24 16:05 benvanik

Yeah. Without this we get different failures on CI and locally like https://github.com/iree-org/iree/issues/16814.

This will need a rebase and some more testing though, so we could close it and delete the branch. I think there were still cache misses (cache size not large enough).

May 13 '24 16:05 ScottTodd

fine with leaving it if it's useful - or can move it to users/stellaraccident - just wanted to make sure it wasn't dead :)

May 13 '24 16:05 benvanik

I should take over this PR and get it landed. Currently debugging issues where a model we're bringing up hits asserts during compilation (we had been testing with asserts disabled and may have missed something because of that). Really want asserts enabled on a wide range of real model CI tests.

Jun 17 '24 23:06 ScottTodd