Ben Vanik
Ben Vanik
feels like a miscompile to me - I have no idea what's going on there (copies and then a load and such)
Wow, this got rebased really wrong. Please fix. If doing a rebase you're uncomfortable with you can use git log (or any other git visualizer) locally before pushing. I'm guessing...
Makes sense with the data type enums being ints if you think they will be extended infrequently (like, with new GPU generations) or are fine with adding enum values that...
lol I'm guessing something is multiplying by a dynamic dimension (sentinel -1) without checking :P
(to reproduce we'll need the batch_llama_3_8B.mlir file, or the entire contents of the `@prefill_bs4$async_dispatch_1_generic_4xDx4096_i64xf32` `flow.executable`/`hal.executable` op prior to the error )
> Not sure why this keeps closing @pashu123 put a "fixes" command in a commit message and now anyone who has write access to the repo will close it when...
I can take a look. globals should be in proper order, though, as initialization is performed as they are declared in the top-level module - probably not the issue here,...
nice - I'll add a pass that runs and verifies globals are in the correct order (declared before use) converttostream requires that globals be converted prior to their uses, so...
Idea for a thousand-papercuts problem: use Pass::initialize more for frozen pattern lists and dynamic pipelines. Today most of our passes create the pattern lists and pipelines in runOnOperation() meaning that...
(don't mind me, just necroing this thread 🧟 :) Systems performing dynamic planning such as [FrameGraph](https://www.gdcvault.com/play/1024612/FrameGraph-Extensible-Rendering-Architecture-in) will suffer from this API limitation. We're building middleware and it hurts especially hard...