benpicco
benpicco
That's exactly what `dac_dds` does too.
To me it feels more like a bug fix than an API change - when I added the functions I was not aware of the difference between `coap_opt_put_uri_pathquery()` and `coap_opt_put_uri_path()`...
Is there anything I can do to move this forward?
I like the idea, but I don't like the name - how about `dynamic_assert` or `const_assert`?
> For this reason, assert_unreachable() is added that can be used instead. A semantic patch has been added, so that the CI will ask contributors to replace assert(0) with assert_unreachable()....
This one needs a rebase
Expecting the user to iterate `coap_opt_get_opaque()` for this is not very user friendly. While I like the idea of querying the desired key directly, it would involve iterating the packet...
We'd still have to copy the value with `coap_get_uri_query(coap_pkt_t *pkt, const char *key, char *value, size_t value_len_max);`, but just that - maybe that's more ergonomic indeed :thinking: (I don't want...
I think even with #20273 this PR is still useful. While `coap_find_uri_query()` is convenient when you only expect a very limited number of URI query options, it gets unwieldy quickly...