benpicco
benpicco
Sorry for the long delay,I almost forgot about this PR :sweat: But I'm very interested, just it's quite a large PR that makes it hard to review. Can you organize...
> uses more stack How?
Yea I guess it's mostly obfuscation at this point…
> falling back to `ZTIMER_USEC` is not acceptable Why?
I still don't see any argument *against* using `ZTIMER_USEC`, where was that brought up? Maybe we should just add the spinning fallback to `xtimer_{u,m}sleep()` and use those through the compat...
@gkostka That's a real bug, `O_RDONLY` is set to `0` in `ext4_oflags.h` so the condition `file->flags & O_RDONLY` will always be false.
Same is true for indefinite maps ```C #include #include #include #include #include #include "nanocbor/nanocbor.h" size_t _encode(uint8_t *buf, size_t len) { nanocbor_encoder_t enc; nanocbor_encoder_init(&enc, buf, len); nanocbor_fmt_map_indefinite(&enc); // nanocbor_fmt_map(&enc, 2); /*...
#21 was merged in the meantime - I think this is still a worthwhile cleanup, but there are several unrelated commits in this PR. What do you think @bergzand ?
Same issue as with #241 :confused:
Arg, I think the problem is that the `libsdl2-dev:i386` package conflicts with `libsdl2-dev` :confused: